Implement iteration over nodes in DFT order; expose it to Cython#531
Closed
d-kad wants to merge 2 commits intogambitproject:masterfrom
Closed
Implement iteration over nodes in DFT order; expose it to Cython#531d-kad wants to merge 2 commits intogambitproject:masterfrom
d-kad wants to merge 2 commits intogambitproject:masterfrom
Conversation
tturocy
requested changes
Jun 28, 2025
tturocy
requested changes
Jun 30, 2025
Contributor
Author
|
@tturocy I implemented node traversal in operator++ with a single children iterator on stack using exception catching mechanism (mirroring your Python code snippet for the PR-checker) |
tturocy
requested changes
Jul 5, 2025
Member
tturocy
left a comment
tturocy
left a comment
There was a problem hiding this comment.
As this looks to be converging well towards a solution please do squash on the next iteration and give a good candidate commit message.
…FT order. Change Python API to use the new nodes iterator. Add tests.
tturocy
requested changes
Jul 8, 2025
tturocy
requested changes
Jul 9, 2025
Member
|
Merged as 89cbddc with some minor adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new nested class,
GameRep::Nodes, which acts as a standard C++ forward iterator.GameRepclass is now directly iterable, through the addition of:begin()andend()methodsIsPerfectRecall().Closes #530